Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial out-of-date #279

Open
xukai92 opened this issue May 6, 2017 · 10 comments
Open

Tutorial out-of-date #279

xukai92 opened this issue May 6, 2017 · 10 comments

Comments

@xukai92
Copy link

xukai92 commented May 6, 2017

I believe the tutorial here: https://clojure-liberator.github.io/liberator/tutorial/getting-started.html is very old. Any plan to update it for the benefit of beginners (like me)?

@ordnungswidrig
Copy link
Member

What parts do you think are outdated?

@jjhop
Copy link
Contributor

jjhop commented Dec 10, 2017

For example versions are outdated

Library Tutorial Current
liberator 0.13 0.15.1
compojure 1.3.4 1.6.0
ring 1.2.1 1.6.3

And also it's worth checking how liberator works with Clojure 1.9, when I tested with the beta versions there were some problems.

@belucid
Copy link
Contributor

belucid commented Dec 10, 2017

I've been using Liberator with the 1.9 alphas, betas and RC's all along and haven't seen any issues. What did you see @jjhop ?

@jjhop
Copy link
Contributor

jjhop commented Dec 11, 2017

Hi @belucid

I've checked again what was the problem. But... there are no problem. My fault, sorry.
The problem (also a little) was with kormasql @1.9RC1

@belucid
Copy link
Contributor

belucid commented Dec 11, 2017

No worries, good to know you didn't find any hidden 1.9 issues. Let's not hijack the issue any longer though, still good to get the tutorial versions up to date.

@jjhop
Copy link
Contributor

jjhop commented Dec 12, 2017

@belucid I could take care of it (and check if these current versions do not cause problems).

@ordnungswidrig
Copy link
Member

I'd appreciate a PR to get the tutorial to modern clojure age very much :)

@ordnungswidrig
Copy link
Member

Regarding 1.9 please feel free to open an issue to track any upcoming related obstacles.

@jjhop
Copy link
Contributor

jjhop commented Dec 12, 2017

Ok, I'll take it.

@jjhop jjhop mentioned this issue Dec 12, 2017
@jjhop
Copy link
Contributor

jjhop commented Dec 12, 2017

@ordnungswidrig pr ready to review/merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants