New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For multimethods, add implementation and dispatch key to document-symbols
#1016
Comments
A few implementation notes:
|
@mainej I think that's potentially interesting, also for detecting duplicate dispatch values which we could warn about. There's already an issue about that here. The dispatch val is always at the same position right? So then the analysis should not be so hard to implement. Feel free to open an issue and a candidate PR. |
@borkdude I'll open an issue. I can't commit to a PR right now. @ericdallo I'm also just helping spec out this problem, not claiming it. It sounds like a quick fix would be to split this into two parts:
|
Agreed @mainej ! |
Is your feature request related to a problem? Please describe.
Multimethod implementations don't show up in Calva outline. Calva uses clojure-lsp to populate the outline view, per @PEZ.
Describe the solution you'd like
I'd like to see both the multifn name and dispatch value show up in the outline. Even just adding the multifn names would be an improvement, if dispatch values required additional or upstream work.
Describe alternatives you've considered
In theory, I could
declare
a dispatch value, but it would require code changes only for this reason, and is a non-starter on the projects I work on.Additional context
Discussion of this particular issue started on #662 with @mainej. Note that I am not certain
document-symbols
is the correct location, but seems highly likely, after conversations.The text was updated successfully, but these errors were encountered: