Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clojure-lsp dump: Allow user to provide clj-kondo analysis configuration #1384

Open
sheluchin opened this issue Nov 20, 2022 · 4 comments
Open
Labels
enhancement New feature or request good first issue Good for newcomers
Projects

Comments

@sheluchin
Copy link

Is your feature request related to a problem? Please describe.
In some cases LSP users may want additional clj-kondo analysis data which LSP currently does not ask for nor need.

Describe the solution you'd like
Allow a clj-kondo analysis config map to be passed in when running the clojure-lsp dump command. This map should be merged with clojure-lsp's existing analysis config.

Adding the option for such user configuration should not conflict with LSP's current operations, because it just extends the data that clj-kondo returns.

Additional context
There is a bit of discussion about this idea in this Slack thread.

@sheluchin sheluchin added the enhancement New feature or request label Nov 20, 2022
@ericdallo ericdallo added this to Low priority in clojure-lsp via automation Nov 21, 2022
@ericdallo ericdallo moved this from Low priority to High priority (Probably next release) in clojure-lsp Nov 21, 2022
@ericdallo
Copy link
Member

This should not be hard to implement, any suggestion for the flag name to dump command?

@sheluchin
Copy link
Author

@ericdallo if brevity is not much of a concern --clj-kondo-analysis-config seems fairly self-explanatory. Otherwise maybe something like --analysis-config, --analysis-overrides, --clj-kondo-config-extras, --clj-kondo-analysis and so on.

@ericdallo
Copy link
Member

I´d like to use the existent --analysis EDN option that now exists after previous commit, WDYT? so maybe we could have --analysis '{:project-type :project-and-dependencies :clj-kondo-overrides {...}}'

@sheluchin
Copy link
Author

Yeah, good point, @ericdallo. That previous ticket already provides the --analysis key to give the clj-kondo context to options, so extending the map here is a good idea 👍

@ericdallo ericdallo moved this from High priority (Probably next release) to Low priority in clojure-lsp Nov 28, 2022
@ericdallo ericdallo added the good first issue Good for newcomers label Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
clojure-lsp
Low priority
Development

No branches or pull requests

2 participants