Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using inline-symbol on a symbol bound via destructuring fails #1764

Open
maxrothman opened this issue Feb 1, 2024 · 0 comments
Open

Using inline-symbol on a symbol bound via destructuring fails #1764

maxrothman opened this issue Feb 1, 2024 · 0 comments
Labels
bug Something isn't working editor Related to clojure-lsp on a text editor good first issue Good for newcomers
Projects

Comments

@maxrothman
Copy link

Describe the bug
Attempting to use the inline-symbol code action/command on a symbol bound via destructuring fails with an error. Given this code, where the cursor position is marked by |:

(let [[x xs] (range 5)]
  (inc x|))
  1. Trigger code actions
  2. Select "Inline symbol"

Expected behavior
The following code is seen in the editor:

(inc (first (range 5))

Actual behavior

  • No changes are made in the editor
  • In the "Clojure Language Client" output panel, I see the following error:
    [Error - 11:54:04 AM] Request workspace/executeCommand failed.
    Message: Internal error
    Code: -32603 
    [object Object]
    
Log - client <-> server
[Trace - 1:12:28 PM] Sending request 'workspace/executeCommand - (17569)'.
Params: {
    "command": "inline-symbol",
    "arguments": [
        "file:///Users/maxrothman/repos/advent-of-code/2023/clj2023/src/clj2023/day19.clj",
        169,
        8
    ]
}

[Trace - 1:12:28 PM] Received response 'workspace/executeCommand - (17569)' in 9ms. Request failed: Internal error (-32603).
Error data: {
"id": 17569,
"method": "workspace/executeCommand"
}

[Error - 1:12:28 PM] Request workspace/executeCommand failed.
Message: Internal error
Code: -32603
[object Object]

User details (please complete the following information):

  • OS: MacOS
  • Editor VSCode (Calva)
  • Version: 2023.12.29-12.09.27
@maxrothman maxrothman added bug Something isn't working editor Related to clojure-lsp on a text editor labels Feb 1, 2024
@ericdallo ericdallo added this to Low priority in clojure-lsp via automation Feb 4, 2024
@ericdallo ericdallo added the good first issue Good for newcomers label Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working editor Related to clojure-lsp on a text editor good first issue Good for newcomers
Projects
clojure-lsp
Low priority
Development

No branches or pull requests

2 participants