You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
the code action to add a namespace results in error when it is an unqualified namespace (like tmp, user).
To Reproduce
Steps to reproduce the behavior:
create namespace
(ns tmp)
(def f inc)
execute code action to require from another namespace, eg for line (tmp/f 2)
Expected behavior
no error
This seems to occur only after the recent code change supporting js-requires PR
culprit seems to be a change in the add-require-suggestion function of add_missing_libspec.clj that transforms chosen-ns to a symbol (line 608). No error occurs when removing this line, but probably it was needed for the new functionality. I don't have the time to look into this in detail right now.
The text was updated successfully, but these errors were encountered:
ericdallo
changed the title
adding require for unqualified namespaces does result in error
Adding require command fails for requires without alias
Mar 16, 2024
Describe the bug
the code action to add a namespace results in error when it is an unqualified namespace (like tmp, user).
To Reproduce
Steps to reproduce the behavior:
(tmp/f 2)
Expected behavior
no error
This seems to occur only after the recent code change supporting js-requires PR
culprit seems to be a change in the
add-require-suggestion
function ofadd_missing_libspec.clj
that transformschosen-ns
to a symbol (line 608). No error occurs when removing this line, but probably it was needed for the new functionality. I don't have the time to look into this in detail right now.The text was updated successfully, but these errors were encountered: