Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alias code action "Add require ... x 1" instead of real count #1794

Closed
NoahTheDuke opened this issue Mar 20, 2024 · 1 comment
Closed

Alias code action "Add require ... x 1" instead of real count #1794

NoahTheDuke opened this issue Mar 20, 2024 · 1 comment
Labels
bug Something isn't working editor Related to clojure-lsp on a text editor
Projects

Comments

@NoahTheDuke
Copy link
Contributor

Describe the bug
Every since #1053, the code action which shows Add require [clojure.string :as str] x N has only shown 1 instead of the total count.

To Reproduce
Steps to reproduce the behavior:

  1. git checkout afc2f6fcee2edd9932c460c397d31ed444741142 (the offending commit)
  2. make debug-cli && chmod +x clojure-lsp
  3. Configure your editor to use clojure-lsp
  4. Open a file with a missing require, run the code action to see the wrong output.
  5. git checkout 54b4251f459375fe9d8943c731368f71ca95e676 (the commit immediately before)
  6. make debug-cli && chmod +x clojure-lsp
  7. Open a file with a missing require, run the code action to see the correct output.

Expected behavior
The total count continues to be shown.

Screenshots
Before the PR:
image

After the PR:
image

User details (please complete the following information):

  • OS: OSX 14.4
  • Editor neovim with coc.nvim and coc-clojure
  • Version: latest but also the two commits above

Additional context
I used git bisect to find the above.

@NoahTheDuke NoahTheDuke added bug Something isn't working editor Related to clojure-lsp on a text editor labels Mar 20, 2024
@ericdallo ericdallo added this to Low priority in clojure-lsp via automation Mar 20, 2024
@ericdallo ericdallo moved this from Low priority to High priority (Probably next release) in clojure-lsp Mar 20, 2024
clojure-lsp automation moved this from High priority (Probably next release) to Next release Mar 30, 2024
@NoahTheDuke
Copy link
Contributor Author

Thanks for fixing, @ericdallo!

@ericdallo ericdallo moved this from Next release to Done in clojure-lsp Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working editor Related to clojure-lsp on a text editor
Projects
Development

No branches or pull requests

1 participant