Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to add project dependencies #461

Open
wandersoncferreira opened this issue Jun 29, 2021 · 2 comments
Open

Support to add project dependencies #461

wandersoncferreira opened this issue Jun 29, 2021 · 2 comments
Labels
enhancement New feature or request
Projects

Comments

@wandersoncferreira
Copy link

Is your feature request related to a problem? Please describe.
While working with clojure projects is common to include new libraries as dependencies. Right now, I am using clj-refactor to provide this functionality (https://github.com/clojure-emacs/clj-refactor.el/wiki/cljr-add-project-dependency) but would be nice to have this in clojure-lsp also.

Describe the solution you'd like
Same behavior as clj-refactor https://github.com/clojure-emacs/clj-refactor.el/wiki/cljr-add-project-dependency but without hot-reload.

Additional context
Something that clj-refactor does not take into account is to verify if a library already exists in your project. Therefore, if you try to include the same dependency more than one time, you will succeed. This could be a stretch goal to be fixed in this new version.

@wandersoncferreira wandersoncferreira added the enhancement New feature or request label Jun 29, 2021
@ericdallo
Copy link
Member

Thank you for the report!

It's a nice custom addition to clojure-lsp IMO, not so easy though. We'd need to create a custom LSP method for that that would request clojars/maven about the available artifacts and return to client so the client could ask for user which one use, after selected the client send again to server asking the available versions, which server requests again and return to client, then user selects the version, send to server and server make the proper changes on files.

@ericdallo ericdallo added this to Low priority in clojure-lsp via automation Jun 30, 2021
@ericdallo
Copy link
Member

I still need to check how clj-refactor requests clojars/maven and if that can cause any "too many requests" error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
clojure-lsp
Low priority
Development

No branches or pull requests

2 participants