Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Removed the sexp-as-fragment code, it's no longer used
- Loading branch information
Showing
3 changed files
with
117 additions
and
88 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
680dc2b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this deleted? It's not used internally, but it's a very valuable external feature, which is why it was added.
680dc2b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it was dead code, sorry about that. I'll get it put back in. Maybe I should add some examples/docs to the readme so users know it's there?
680dc2b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. There was one in the tests, but I suppose that makes it look like an internal feature. It exists to let prxml/hiccup users use the same "interface" (data structures) in data.xml without any hassle. So maybe just an example showing that (emit (sexp-as-element [:tr [:td 'whatever]])) emits valid HTML?
680dc2b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just pushed up a commit to roll the change back. A basic example like that in the readme would be fine. I'll add it tomorrow unless you beat me to. Once it's in I'll cut another release.
680dc2b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need a release cut or have you already done it?
680dc2b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
680dc2b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. I just want to make sure it gets out if folks need it.
680dc2b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added an example to the README and cut an 0.0.6 release.