Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Delete By Query for Elasticsearch 5 #256

Closed
hantuzun opened this issue Sep 8, 2017 · 4 comments
Closed

Fix Delete By Query for Elasticsearch 5 #256

hantuzun opened this issue Sep 8, 2017 · 4 comments

Comments

@hantuzun
Copy link
Contributor

hantuzun commented Sep 8, 2017

Elasticsearch 5 has updated Delete By Query methods with POST .../_delete_by_query signatures.

I've fixed elastisch for that, but forking from
@wneirynck's open pull request #252 here: https://github.com/hantuzun/elastisch
@hantuzun hantuzun mentioned this issue Sep 8, 2017
Merged
@michaelklishin
Copy link
Member

@hantuzun you can change base fork and branch when creating a pull request. Please do that instead.

@hantuzun
Copy link
Contributor Author

hantuzun commented Sep 9, 2017

@michaelklishin, I'd like to do that when Elastisch will have an Elasticsearch 5.x branch...

@hantuzun
Copy link
Contributor Author

Hi @michaelklishin,

Since @wneirynck's PR is now merged to the master, should I create a new PR for this fix?

@michaelklishin
Copy link
Member

@hantuzun please do, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelklishin @hantuzun