Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing API-key method signature for create Customer #12

Closed
jonassvalin opened this issue Nov 2, 2018 · 1 comment
Closed

Missing API-key method signature for create Customer #12

jonassvalin opened this issue Nov 2, 2018 · 1 comment
Labels

Comments

@jonassvalin
Copy link

Version
1.0.0-beta18

Behaviour
The customer "Create" function only has one method signature, which does not take an API-key.

(defn ^IPersistentMap create [^IPersistentMap m] (cnv/customer->map (Customer/create m)))

Expected behaviour
The customer "Create" function should have an additional method signature which takes the API-key. Something similar to the charge "Create" function:

(defn create ([m] (cnv/charge->map (Charge/create (wlk/stringify-keys m)))) ([^String api-key m] (cnv/charge->map (Charge/create (wlk/stringify-keys m) api-key))))

Additional info
It is my understanding that you would need to pass your API-key to actually create real customers tied to your Stripe account. Am I correct that this is currently a missing feature? If so, would you encourage a pull request to add this?

Thanks!

@michaelklishin
Copy link
Member

Your understanding is incorrect. API key is set globally in the Stripe client, see integration tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants