Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the consumer in the throughput tests truly do no work. #6

Closed
leifp opened this issue Jan 8, 2014 · 1 comment
Closed

Make the consumer in the throughput tests truly do no work. #6

leifp opened this issue Jan 8, 2014 · 1 comment

Comments

@leifp
Copy link

leifp commented Jan 8, 2014

Due to reflection, the throughput tests aren't giving the correct impression of the throughput/overhead of the library.

If you add a ^CountDownLatch type hint to the consumer:
https://github.com/clojurewerkz/meltdown/blob/master/test/clojurewerkz/meltdown/throughput_test.clj#L35

This gives me a 10x speedup using RingBufferDispatcher, and the events/second for a no-op consumer are in the millions, as advertised.

@michaelklishin
Copy link
Member

I now enabled reflection warnings and there seem to be a whole bunch of other cases where reflection is used (likely not on the hot path, though). Feel free to submit a pull request that correct more of that stuff and thanks for finding this out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants