Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch is no working since r295777 #11

Closed
dpino opened this issue Aug 16, 2022 · 3 comments
Closed

Fetch is no working since r295777 #11

dpino opened this issue Aug 16, 2022 · 3 comments

Comments

@dpino
Copy link
Contributor

dpino commented Aug 16, 2022

Revision r295777 was the last revision commited into SVN (6c074d1e52c555d43db5738caf6007c988b85ff3). Since then, the script fetch.sh is failing as it tries to parse a SVN revision id.

$ ./fetch gtk-release
Fetching results for bot: GTK-Linux-64-bit-Release-Tests
...............
r295768... :
r295769... :
r295770... :
r295772... :
r295774... :
r295776... :
r295777... :
rNone... Fatal: Revision should be numeric and I got revision "None" for http://build.webkit.org/results/GTK-Linux-64-bit-Release-Tests/251785%40main%20%288057%29/full_results.json

Worst of all, it seems there's no equivalent identifier in the fetched JSON results.

@clopez
Copy link
Owner

clopez commented Sep 9, 2022

The json files uploaded by the bots have a null value on the revision field.

I have opened this upstream in order to fix it: https://bugs.webkit.org/show_bug.cgi?id=244960

Once this lands upstream, we have to do several changes here to fix this issue:

  1. Download the json files from the server that have the null value as revision and update the field (we can guess the revision number from the URL)
  2. For consistency reasons is a good idea also to do a massive rename of the current already download json results to update them from the old svn-rev-numbers to the new style of IDs of number@main.
  3. Adapt the program to work with the new IDs instead of SVN revision numbers
  4. Remove from the program the initial check of the SVN server to guess the initial revision adding the test, since SVN not longer works

@clopez
Copy link
Owner

clopez commented Sep 14, 2022

I have updated all the json files with the new identifiers and also updated the code to work with the new identifiers.
This are the commits merged into master:

02a6201 Update code to work with the new Git identifiers
8639ae7 Update results from fetch
d47bf5e Update fetch to only accept the new Git format for identifiers
18dd008 Remove helper scripts used for the mass-renaming and update to Git identifiers
0e9689f Rename results to the new Git identifiers (6 and last)
066aef5 Update revision field in results to the new Git identifiers (5)
144097a Rename results to the new Git identifiers (4)
0c2e20f Remove results from SVN revisions that don't have a Git identifier (3)
461deb9 Update missed key in svn-to-id dict
c2321f5 Update revision field in results to the new Git identifiers (2)
d3bf1ba Rename results to the new Git identifiers (1)
1bc7bef rename script: stage in two steps the rename and the update
b1502e5 Update jsonresults again before renaming
13bde9b Add helper scripts used for the mass-rename and fixes from svn to git
d31be33 Update the jsonresults after fixing fetch
e4933ac fetch: Allow to download results after migration to GIT.

Note: git pull will take a while the first time because all of the json results were overwritten (and there are a lot of them)

@clopez
Copy link
Owner

clopez commented Sep 14, 2022

I'm closing this, please re-open if something doesn't work.

@clopez clopez closed this as completed Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants