-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timezone information missing under python 3.5 #18
Comments
Hmm, I've added 3.5 to travis and can't seem to reproduce this - https://travis-ci.org/prymitive/ciso8601/jobs/171866331 |
I wanted to run tests with fedora docker image and noticed that pytz is installed when running tests. I've installed it in my virtualenv and now everything works. So this seems to be simply missed dependency which is mentioned in the README (I've missed that, sorry). |
It should probably do a better job at failing in https://github.com/closeio/ciso8601/blob/master/module.c#L245 I think right now it leaves |
Opened #19 to address this |
I've noticed that when I'm parsing timestamp with timezone information under python 3.5 project I'm getting timezone unaware datetime objects:
Using
ciso8601==1.0.2
in both cases. Tested on Fedora 24 with distro provided python binaries.The text was updated successfully, but these errors were encountered: