-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compilation warnings #52
Comments
There are several compilation warnings right now, depending on the Python version: Python 2.7
Python 3.7
Python 3.6 on Windows:
There are also 2 warnings from Python about missing metadata in
I'll create a PR to fix all these. The code doesn't get any cleaner, but it might be nice to be able to fail the CI on new warnings. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Variable declaration should be wrapped in #ifdef for Python versions where it's not needed (I believe >= 3.2).
Also, should we trigger errors on compile warnings to catch these?
The text was updated successfully, but these errors were encountered: