This repository has been archived by the owner on Jan 23, 2024. It is now read-only.
Don't return parent's child_document_resources in subclasses. #87
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, don't inherit
child_document_resources
. This lets us have multiple resources for a child document without having to reset thechild_document_resources
property in the subclass.Consider the following example:
If we call
VerboseChildResource().serialize(obj)
, before this PR it would delegate the call toChildResource
sinceVerboseChildResource
would inheritchild_document_resources
fromParentResource
. This is usually not expected behavior, so I'm changingget_child_document_resources
to only return the current class'child_document_resources
. In the rare case where this isn't desirable, a parent can always explicitly change the behavior by overridingget_child_document_resources
.