Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop dependency on thread_safe #26

Closed
fmluizao opened this issue Sep 5, 2017 · 3 comments
Closed

Drop dependency on thread_safe #26

fmluizao opened this issue Sep 5, 2017 · 3 comments

Comments

@fmluizao
Copy link
Contributor

fmluizao commented Sep 5, 2017

Hi,

I was wondering why the gem thread_safe is listed as a runtime dependency in the gemspec... Inspecting the code I see no usage of this gem... Could it be removed? This gem was merged into concurrent-ruby and is deprecated.
@mceachen
Copy link
Collaborator

mceachen commented Sep 6, 2017

I just reviewed the commit that added the runtime dependency. It may have been to make an ancient ruby/active_record combination pass in CI, but that time has long passed.

I'll happily merge a PR that removes this. Thanks for the catch!

@fmluizao fmluizao closed this as completed Sep 8, 2017
@fmluizao
Copy link
Contributor Author

fmluizao commented Oct 6, 2017

Could you release a new version please?

@mceachen
Copy link
Collaborator

mceachen commented Oct 6, 2017

Just pushed v3.2.0 -- thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fmluizao @mceachen