tweak _.shuffle

clottes · Feb 8, 2013 · adc778a · adc778a
1 parent 7615764
commit adc778a
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/underscore.js b/underscore.js
@@ -740,12 +740,10 @@ var till = _.till = _.until = function(obj, iterator, context, pass) {
 
   // Shuffle an array.
   _.shuffle = function(obj) {
-    var rand;
+    var shuffled = [], rand;
-    var index = 0;
+    each(obj, function(value,index) {
-    var shuffled = [];
+      rand = Math.floor(Math.random() * (index + 1));
-    each(obj, function(value) {
+      shuffled[index] = shuffled[rand];
-      rand = _.random(index++);
-      shuffled[index - 1] = shuffled[rand];
       shuffled[rand] = value;
     });
     return shuffled;