Skip to content

Commit

Permalink
CNI workload: Change the probe from readinessProbe to startupProbe.
Browse files Browse the repository at this point in the history
This patch changes the probe in curl-deployment.yml from
readinessProbe to startupProbe for the following reasons:

 - readinessProbe is periodic and with default period interval of 1
   second, it significantly loads kubelet effecting the pod
   readiness as the scale increases.

 - startupProbe is enough to check if CNI has done its job of wiring
   the networking of the pods.

 - Below are the tests on AWS 120 node cluster with 4000 iterations
   of kubelet-density-cni

   With readinessProbe - ContainerReady
   -----------------------------------
    "P99": 80928,
    "P95": 66161,
    "P50": 9526,
    "max": 671045,
    "avg": 19321,

   With startupProbe - ContainerReady
   -----------------------------------
    "P99": 11872,
    "P95": 9609,
    "P50": 4862,
    "max": 18487,
    "avg": 5329,

Signed-off-by: Numan Siddique <nusiddiq@redhat.com>
  • Loading branch information
numansiddique authored and rsevilla87 committed Mar 7, 2022
1 parent d7b1463 commit 1c83504
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,15 @@ spec:
imagePullPolicy: IfNotPresent
securityContext:
privileged: false
readinessProbe:
startupProbe:
exec:
command:
- "/bin/sh"
- "-c"
- "curl ${WEBSERVER_HOSTNAME}:${WEBSERVER_PORT}"
periodSeconds: 1
timeoutSeconds: 60
failureThreshold: 600
restartPolicy: Always
replicas: 1
selector:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,15 @@ spec:
imagePullPolicy: IfNotPresent
securityContext:
privileged: false
readinessProbe:
startupProbe:
exec:
command:
- "/bin/sh"
- "-c"
- "curl ${WEBSERVER_HOSTNAME}:${WEBSERVER_PORT}"
periodSeconds: 1
timeoutSeconds: 60
failureThreshold: 600
restartPolicy: Always
replicas: 1
selector:
Expand Down

0 comments on commit 1c83504

Please sign in to comment.