Fix retry logic in create functions

Signed-off-by: Raul Sevilla <rsevilla@redhat.com>
kube-burner · Apr 6, 2021 · 6d42586 · 6d42586
1 parent b27b00c
commit 6d42586
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/pkg/burner/create.go b/pkg/burner/create.go
@@ -220,14 +220,14 @@ func createRequest(gvr schema.GroupVersionResource, ns string, obj *unstructured
 				return true, err
 			} else if errors.IsAlreadyExists(err) {
 				log.Errorf("%s/%s in namespace %s already exists", obj.GetKind(), obj.GetName(), ns)
-				return true, err
+				return true, nil
 			} else if errors.IsTimeout(err) {
 				log.Errorf("Timeout creating object %s/%s in namespace %s: %s", obj.GetKind(), obj.GetName(), ns, err)
 			} else if err != nil {
 				log.Errorf("Error creating object: %s", err)
 			}
 			log.Error("Retrying object creation")
-			return false, err
+			return false, nil
 		}
 		log.Infof("Created %s/%s in namespace %s", uns.GetKind(), uns.GetName(), ns)
 		return true, err

diff --git a/pkg/burner/namespaces.go b/pkg/burner/namespaces.go
@@ -42,7 +42,7 @@ func createNamespace(clientset *kubernetes.Clientset, namespaceName string, nsLa
 			return true, err
 		} else if err != nil {
 			log.Errorf("Unexpected error creating namespace %s: %s", ns.Name, err)
-			return false, err
+			return false, nil
 		}
 		log.Infof("Created namespace: %s", ns.Name)
 		return true, err