Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] Index subcommand shouldn't require a config file #384

Closed
rsevilla87 opened this issue Jul 18, 2023 · 0 comments · Fixed by #417
Closed

[RFE] Index subcommand shouldn't require a config file #384

rsevilla87 opened this issue Jul 18, 2023 · 0 comments · Fixed by #417
Labels
enhancement New feature or request

Comments

@rsevilla87
Copy link
Member

Is your feature request related to a problem? Please describe.
At the moment the index subcommand requires a configuration file:

https://github.com/cloud-bulldozer/kube-burner/blob/6dd21f142b4f869b7153531e9faefde488616000/cmd/kube-burner/kube-burner.go#L235

This requirement is mainly because there's no way to configure the indexer from this cmd.

Describe the solution you'd like

I think we could add some new flags to this sub-command in order to prevent requiring this configuration file going forward.

Describe alternatives you've considered

Some examples I've came up with:

$ kube-burner index -u http://prometheus.com:9090 -t myToken --es-server=https://elastic.com:9200 --es-index=foobar
$ # or
$ kube-burner index -u http://prometheus.com:9090 -t myToken --local-indexing
$ # or
$ kube-burner index -u http://prometheus.com:9090 -t myToken --tarball
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant