Fix QPS in non-optimal scenarios #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsevilla87
force-pushed
the
fix-qps
branch
3 times, most recently
from
d0775d7
to
e11bc92
Compare
Signed-off-by: Raul Sevilla <rsevilla@redhat.com>
rsevilla87
added a commit
to rsevilla87/kube-burner
that referenced
this pull request
Nov 21, 2023
Signed-off-by: Raul Sevilla <rsevilla@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Raul Sevilla rsevilla@redhat.com
Description
The original implementation uses creates a new go-routine per replica, in scenarios where there's only one object replica per iteration (node-density), kube-burner might not reach the configured QPS ratio . This is more likely in scenarios where there're some delay from the API, like when network latency with the API is not 100% optimal.
This new implementation makes API calls not blocker since they are now encapsulated in their own go-routines.