Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C7N Mailer - Allow Redis cluster to have encryption in transit enabled #7841

Open
mrjeffwagner opened this issue Oct 5, 2022 · 3 comments
Open

Comments

@mrjeffwagner
Copy link

Describe the feature

The C7N Mailer tool does not allow for the Redis cluster to have Encryption in Transit enabled, which causes an error with the mailer lambda where it hangs for 15 minutes due to connectivity to Redis failing.

self.connection = redis.StrictRedis(host=redis_host, port=redis_port, db=db)

I have tested the redis library locally with the following command and I am able to successfully get a connection:

ssl = redis.StrictRedis(host=redis_host, port=redis_port, ssl=True)
ssl.ping()
True

Feature request would likely be to add another option to config.yaml that can accept True/False value for redis_encryption, then add that to Redis class init.

Extra information or context

No response

@ajkerrigan
Copy link
Member

Thanks for the report @mrjeffwagner , this request makes sense 👍 . Supporting an optional ssl parameter in the mailer config would be one way to handle this. Another might be allowing url rather than the host / port combo, and feeding that to Redis.from_url(). That handles port, db and the optional redis/rediss tls distinction under the covers 🤔

@kapilt
Copy link
Collaborator

kapilt commented Oct 6, 2022

redis url sounds good

@sanjeev98kumar
Copy link

Will this be a good first issue to start with?I am looking for my first PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants