Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws - add delete action to directory and cloud-directory #8610

Merged
merged 22 commits into from
Jun 22, 2023

Conversation

timmygrable
Copy link
Contributor

Closes #8609

@timmygrable timmygrable requested a review from kapilt as a code owner May 30, 2023 14:45
@timmygrable timmygrable changed the title add delete action to directory and cloud-directory resources aws - add delete action to directory and cloud-directory May 30, 2023
c7n/resources/directory.py Outdated Show resolved Hide resolved
c7n/resources/directory.py Outdated Show resolved Hide resolved
@PratMis
Copy link
Collaborator

PratMis commented Jun 5, 2023

Looks good to me. @ajkerrigan / @thisisshi, when you get a second do you mind taking a second look please? Thanks

Copy link
Member

@ajkerrigan ajkerrigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these @timmygrable ! I've got a question inline about timing and validation for disable/delete operations, but this looks generally good to me 👍

c7n/resources/directory.py Outdated Show resolved Hide resolved
c7n/resources/directory.py Show resolved Hide resolved
@kapilt
Copy link
Collaborator

kapilt commented Jun 21, 2023

we tightened the lint/fmt validations, so this pr needs a revisit on a few lines

ruff c7n tests tools
Error: c7n/resources/directory.py:217:1: W293 Blank line contains whitespace
make: *** [Makefile:64: lint] Error 1
Error: c7n/resources/directory.py:225:33: W292 No newline at end of file
Error: tests/test_directory.py:53:1: W293 Blank line contains whitespace
Error: tests/test_directory.py:75:60: W291 Trailing whitespace
Error: tests/test_directory.py:76:1: W293 Blank line contains whitespace
Error: tests/test_directory.py:84:49: W291 Trailing whitespace
Error: tests/test_directory.py:138:1: W293 Blank line contains whitespace
Error: Process completed with exit code 2.

running make format should address.

Copy link
Collaborator

@kapilt kapilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kapilt kapilt merged commit 754598b into cloud-custodian:main Jun 22, 2023
21 checks passed
@timmygrable timmygrable deleted the delete-action-directorys branch June 22, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws - delete action of directory/cloud-directory services
4 participants