-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws - add delete action to directory and cloud-directory #8610
aws - add delete action to directory and cloud-directory #8610
Conversation
Looks good to me. @ajkerrigan / @thisisshi, when you get a second do you mind taking a second look please? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding these @timmygrable ! I've got a question inline about timing and validation for disable/delete operations, but this looks generally good to me 👍
we tightened the lint/fmt validations, so this pr needs a revisit on a few lines
running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Closes #8609