Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Ruby 3.1 #2293

Closed
3 tasks done
drewbo opened this issue Apr 6, 2023 · 2 comments
Closed
3 tasks done

Upgrade to Ruby 3.1 #2293

drewbo opened this issue Apr 6, 2023 · 2 comments
Assignees
@drewbo
Labels
squad-pages

Comments

@drewbo
Copy link
Contributor

drewbo commented Apr 6, 2023 •
edited by apburnes
Loading

Ruby 2.7 is EOL. Upgrading will require removing jekyll-assets as it does not run with Ruby 3

Notes

Acceptance Criteria

  • Remove jekyll-assets
  • Update dependencies as needed
  • Runs on Ruby 3.1
@drewbo
Copy link
Contributor Author

drewbo commented Apr 7, 2023

Looking through this more, it looks like jekyll-assets has been handling the following things for us:

  • "finding" assets by basename + fingerprinting:
  • sass compilation
  • css autoprefixing
  • image compression

The first two can likely be handled via jekyll, updating our folder structures, and a small gulpfile for capturing assets from node_modules. The latter two are likely going to require node modules rather than jekyll gems because the jekyll support for assets pipeline operations seems mostly deprecated.

@drewbo
Copy link
Contributor Author

drewbo commented Apr 26, 2023

Closed via #2296

@drewbo drewbo closed this as completed Apr 26, 2023
@drewbo drewbo self-assigned this Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drewbo drewbo

Labels
squad-pages
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@drewbo