Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve de/provision UX in admin client #3727

Closed
3 tasks done
svenaas opened this issue Dec 9, 2021 · 8 comments
Closed
3 tasks done

Improve de/provision UX in admin client #3727

svenaas opened this issue Dec 9, 2021 · 8 comments
Assignees

Comments

@svenaas
Copy link
Contributor

svenaas commented Dec 9, 2021

User Story

As an admin administering a domain from its show page I want to provision or deprovision that domain and see the appropriate action button update below the domain details.

Background (Optional)

Currently, when viewing a domain in the "pending" state, if an admin presses the "Provision" button the domain moves into the "provisioning" state, and the client begins periodically checking to update the status information displayed. But it does not correctly update the button — the "Provision" button goes away, which is a good start, but once the domain is in the "provisioning" state the "Provision" button should be replaced with a "Deprovision" button, which is indeed displayed if the user fully refreshes the page.

Acceptance Criteria

  • Correctly update the correct action button (Provision or Deprovision) and its state (enabled/disabled) after the button has been pressed, without requiring the admin user to fully reload the page.

Level of effort - <low/medium/high>

low

Implementation outline (if higher than "low" effort):

  • The domain state is already updated after the Provision/Deprovision button is pressed; this code should be expanded to also update the button.
  • Deployed
@svenaas svenaas self-assigned this Feb 4, 2022
@svenaas
Copy link
Contributor Author

svenaas commented Feb 4, 2022

I think this may be as simple as calling refreshDnsResults(); after making the provisionDomain() or deprovisionDomain() call.

@svenaas
Copy link
Contributor Author

svenaas commented Feb 4, 2022

PR created, but not yet reviewed/approved/merged into staging.

@svenaas
Copy link
Contributor Author

svenaas commented Feb 11, 2022

#3772 approved and merged. We will need to test it on provision and deprovision in staging to see whether it works or whether there are issues — the thing I'm uncertain about is timing.

@svenaas
Copy link
Contributor Author

svenaas commented Feb 15, 2022

This, unfortunately, does not do what I hoped it would in staging.

@svenaas
Copy link
Contributor Author

svenaas commented Feb 15, 2022

Trying again with #3781.

@svenaas
Copy link
Contributor Author

svenaas commented Feb 15, 2022

This one's looking better on staging, but it takes a while to test because I have to wait for de/provisions to complete. I just successfully started a provision, saw the refresh work, immediately deprovisioned, and saw that work as well. I'm waiting for that to complete and will then try the two actions individually to be sure before I move this one to Done.

@svenaas
Copy link
Contributor Author

svenaas commented Feb 15, 2022

Works great on provision. The delete button goes away and the deprovision button appears.

@svenaas
Copy link
Contributor Author

svenaas commented Feb 15, 2022

Works great on deprovision too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants