Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vhost-user: Implement VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS #1460

Closed
dagrh opened this issue Jul 14, 2020 · 4 comments
Closed

vhost-user: Implement VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS #1460

dagrh opened this issue Jul 14, 2020 · 4 comments

Comments

@dagrh
Copy link
Contributor

dagrh commented Jul 14, 2020

The vhost user protocol has a limit of ~8 memory slots it can handle; that's an issue when you add lots of DIMMs, e.g. in Kata when you have lots of containers in a pod: (Related to kata-containers/runtime#2795 )
QEMU recently got support for VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS which does away with the limit on the slots.
We need to get the same feature.

Easiest way to trigger it is to start a vhost_user_fs and then connect a qemu with:

   -m 2G,maxmem=16G,slots=16 -object memory-backend-memfd,id=mem1,size=256M,share=on -device pc-dimm,id=dimm1,memdev=mem1 -object memory-backend-memfd,id=mem2,size=256M,share=on -device pc-dimm,id=dimm2,memdev=mem2 -object memory-backend-memfd,id=mem3,size=256M,share=on -device pc-dimm,id=dimm3,memdev=mem3 -object memory-backend-memfd,id=mem4,size=256M,share=on -device pc-dimm,id=dimm4,memdev=mem4 -object memory-backend-memfd,id=mem5,size=256M,share=on -device pc-dimm,id=dimm5,memdev=mem5 -object memory-backend-memfd,id=mem6,size=256M,share=on -device pc-dimm,id=dimm6,memdev=mem6 -object memory-backend-memfd,id=mem7,size=256M,share=on -device pc-dimm,id=dimm7,memdev=mem7 -object memory-backend-memfd,id=mem8,size=256M,share=on -device pc-dimm,id=dimm8,memdev=mem8
@rbradford
Copy link
Member

@slp I think this should be moved....

@slp
Copy link
Member

slp commented Jan 28, 2021

@rbradford Yes, it'd be nice to have this one in https://github.com/rust-vmm/vhost. Do you have the possibility to move this issue there to avoid creating it from scratch?

@rbradford
Copy link
Member

No, GitHub does not let you move across organisations.

@slp
Copy link
Member

slp commented Jan 28, 2021

@rbradford Ouch. Well, I created a new issue manually rust-vmm/vhost#17

I think this one can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Release 0.10.0
  
To do
Development

No branches or pull requests

3 participants