New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open to the idea of a features list? #4121
Comments
Looks like a good addition. I'd personally put the definitions below the actual list, but I can see it both ways |
@iggy right. When I did the original work, there were only a few definitions. Now there are like 20 :) - I think we could start smaller, and tune to our liking. Cheers, |
@sdake Sounds good. Looking forward to your contribution! |
@weltling Would you be adversely affected if I worked to lift the unstable features and better define the stability guarantees from a few parts excellent release document in PR #3957. I don't want to duplicate work, although I do want to formalize the feature list in this issue and precisely define the feature maturity as part of that list. I plan to do this as three PRs that can independently review - which can merge into one or merge independently.
For an example of what this looks like taken to the extreme, see the Istio feature stages. I am not a fan of the overly ambitious support model of Istio, but I am a fan of defining for our users exactly what the upstream support model is. Thank you, |
By trade, I am not a technical writer. However, to learn the codebase and the project, I must undertake some technical writing work, so thank you in advance for tolerating my technical writing expertise. This proposal is copied and reformatted from a comment I made in the the LTS proposal.
When we undertook this work in Istio, the Initail Istio Feature Stages held significant community interest. Unfortunately, the latest version of the Istio feature stages was rebased improperly, resulting in lost commit history, groan, but shows how this work could evolve if we so choose. Thank you, |
@sdake You should also look at https://github.com/cloud-hypervisor/cloud-hypervisor/blob/main/docs/device_model.md for more inspiration (it's somewhat out of date though.) |
Thank you. I have read and read the docs directory as well as reading the src code, especially config.rs, I have plenty of notes, and working on organizing them into a PR, definitely today. One thing that is undocumented, and I am not sure if it is intentional or not, are the perf and scale expected behaviors. I would have liked to see the performance (memory, CPU, network) with vhost user net - i.e., https://github.com/cloud-hypervisor/cloud-hypervisor/blob/main/docs/vhost-user-net-testing.md I have found https://github.com/cloud-hypervisor/cloud-hypervisor/blob/main/docs/performance_metrics.md of course, but I rather test the bring-up with the howtos. If you have suggestions here, welcome to hear em. :) Cheers, |
@sdake The performance you get with vhost-user-net is highly dependent on how you configure that backend you talk to with it. DPDK is the most common one and has a huge number of options for configuring it including using userspace drivers for the network interface. As the VMM we don't really provide recommendations on how the customer can use the code. |
@rbradford thanks, I will not add scale and perf to the feature list. Also thank you for the keyword Cheers, |
@sdake thanks for looking into this effort. Yes, a reified commitment to stability was one of the goals in the release doc discussion. With regard to the features also - connecting feature stability to the release cycle would be a promise definition to be given to the consumer. With the table listing the stage terminology of dev, alpha, beta and so on - i would know it more related to the release cycle as that's where it's applied to the versioning to indicate stablity. An alpha release would refer to the product version as a whole. Nevertheless, the idea of defining features stability separately could be applicable, too. Perhaps this should be conditioned by the fact that the default features (eg. Thanks |
Hi Gang,
First off, cloud-hypervisor is pretty awesome. Like many open source projects, the documentation could use a bit of a tuneup. The biggest impact feature I can think of that would help people get moving is, strangely, a feature list.
As my first foray into producing a useful contribution to this project, I'd like to do this basic feature list. I assembled this feature list for Istio: https://istio.io/latest/docs/releases/feature-stages/
If one of the maintainers would be so kind as to accept this proposal by assigning this issue to me, I would appreciate it.
Cheers,
-steve
The text was updated successfully, but these errors were encountered: