Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Gateway support #6

Open
TylerHendrickson opened this issue Feb 15, 2018 · 1 comment
Open

API Gateway support #6

TylerHendrickson opened this issue Feb 15, 2018 · 1 comment

Comments

@TylerHendrickson
Copy link

This service seems really promising and provides a lot of the functionality I've been looking for. However, I was trying a few things out and it doesn't look like the features that Chalice offers (specifically, API Gateway integration based on functions defined with the @app.route decorator) work when using Domovoi.

Is this intentional? It would be excellent if we could use Domovoi to extend Chalice's existing functionality.

Additionally, since both Domovoi and Chalice rely on an app.py file defining an app variable, it doesn't seem very feasible to use both the Domovoi and Chalice CLI tools within the same project. While I'd prefer to just be able to use Domovoi for everything, this would be an acceptable alternative.

Are there plans to provide support for API Gateway within Domovoi? Thanks for your help!

@kislyuk
Copy link
Collaborator

kislyuk commented Feb 16, 2018

The point of Domovoi is to provide an easy way to hook up Lambdas to various events in AWS. To that end it reuses a lot of the machinery that Chalice developed for packaging and deploying Lambdas, and turns off the parts that it doesn't need. The short term way to do what you want is to deploy one app with Chalice, another app with Domovoi, and throw code that's shared between the two into chalicelib/domovoilib.

What you describe is possible, but would require a bunch of changes to how Domovoi patches Chalice behavior. It also has the potential to unnecessarily couple both the deployment process and the entry point behavior of Domovoi to the semantics of API Gateway and the Chalice entry point that it overloads.

Chalice has limited support for mixing "pure Lambda functions" with API Gateway handlers. Chalice authors have also put a lot of thought into making Chalice do more event handling of the kind that Domovoi allows:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants