Skip to content
This repository has been archived by the owner on May 31, 2023. It is now read-only.

Preflight "tags: always" conflicts with --tags option #101

Closed
akx opened this issue Oct 1, 2018 · 5 comments
Closed

Preflight "tags: always" conflicts with --tags option #101

akx opened this issue Oct 1, 2018 · 5 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@akx
Copy link

akx commented Oct 1, 2018

Hi hi!

I have a playbook that configures a full Prometheus + Grafana stack on a node via task dependencies, with each dependency tagged, e.g. tags: prometheus, tags: grafana.

The problem here is that if I just want to run Prometheus reconfiguration (--tags=prometheus), bits and pieces of Grafana stuff still gets run, since tags: always overrides command line --tags.

This is compounded by the fact that I have, as best practices dictate, the Grafana password stored as an Ansible vaulted variable. This means "Fail when grafana admin password isn't set" fails even if I don't want to touch the Grafana configuration at all, if I haven't somehow entered the vault password.

@paulfantom paulfantom added help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest labels Oct 4, 2018
@rlex
Copy link

rlex commented Oct 12, 2018

Somewhat simular issue here. Is there any reason why preflight is set as always run?

@paulfantom
Copy link
Member

There is no reason. It is a bug and needs to be fixed.

@krzyzakp
Copy link
Contributor

krzyzakp commented Nov 8, 2018

I created PR #109 which shoul solve this issue, it passed checks (finally - needed to find, that pytest 3.10.0 is broken). @paulfantom could you take a look on it?

@paulfantom
Copy link
Member

Closing since #109 should solve this issue

@lock
Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants