Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource for VPC #133

Closed
orlandothoeny opened this issue Dec 3, 2021 · 6 comments
Closed

New Resource for VPC #133

orlandothoeny opened this issue Dec 3, 2021 · 6 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@orlandothoeny
Copy link
Contributor

To be able to manage the whole lifecycle of a VPC, a new resource type would be good.

There is currently no way to delete a VPC using this provider. It either has to be done using the API or the web UI.

@dentarg dentarg added the enhancement New feature or request label Dec 3, 2021
@AlexRex
Copy link

AlexRex commented Jan 4, 2022

Also for me, it looks like after destroying the stack the VPC stills there. I guess is because Terraform doesn't know about this VPC at all..

@luiselizondo
Copy link

Actually I'm seeing something different, the VPC is destroyed after the instance is deleted and if the VPC is left with no instances at all. Managing the creation of VPCs should be a must for this plugin.

@dentarg
Copy link
Member

dentarg commented Feb 22, 2022

Yes, until we have added the resource to manage VPCs, empty VPCs are automatically deleted when you remove an instance using the API. This behaviour may change in the future.

@tbroden84 tbroden84 added this to the v2.0.0 milestone Mar 21, 2022
@tbroden84
Copy link
Contributor

We have done development and testing to add the managed VPC resource. Unfortunately will introduce breaking changes and affect multiple resources. After internal discussion we decided move forward to create a new major version for this.

Example of breaking changes:

  • Instance: will never remove VPC when deleted. (Previous behaviour due to our underlying API).
  • Instance: no longer able to create VPC
  • VPC peering, info: dependency to VPC resource (Previous dependency to instance).

@tbroden84
Copy link
Contributor

After even more internal discussion and testing. We found out it was possible to make it work without breaking changes. We will release v1.16.0 with the new managed VPC resource. Then put the above mention breaking changes into the next major release.

@tbroden84
Copy link
Contributor

Just released v1.16.0 with managed VPC resource.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants