Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: allow handling a single firewall rule #211

Open
ralbertazzi opened this issue Jun 29, 2023 · 2 comments
Open

Feature: allow handling a single firewall rule #211

ralbertazzi opened this issue Jun 29, 2023 · 2 comments
Labels
api or backend Needs to be addressed in the API backend enhancement New feature or request

Comments

@ralbertazzi
Copy link
Contributor

ralbertazzi commented Jun 29, 2023

The current cloudamqp_security_firewall requires one to track all firewall rules. This however creates a conflicting situation when:

  • we'd like some rules - such as the ones related to VPC peering - to stay fixed and be tracked on Terraform
  • we'd like some other rules - such as the ones that allow human users to access RabbitMQ from their workstation - to change over time and even be edited manually

During this situation, Terraform will now propose a firewall change every time one manually edits the firewall rules. Considering that one use case of opening a firewall rule is to apply Terraform resources on the internal RabbitMQ instance, this effect is deleterious. We currently decided not to track firewall rules on Terraform because of this.

We'd like a Terraform resource that allows us tracking a single firewall rule. This way we could have both "static" rules (tracked on Terraform) and "dynamic" rules (edited manually) without Terraform creating unneeded diffs.

The server API to achieve this should already be there, aka the PATCH https://api.cloudamqp.com/api/security/firewall

When running terraform plan or apply, it would be nice to fetch all single-rule resources through a single API call to GET https://api.cloudamqp.com/api/security/firewall, even if multiple single-rule resources are defined.

@dentarg dentarg added the enhancement New feature or request label Jun 29, 2023
@dentarg
Copy link
Member

dentarg commented Jun 29, 2023

Sounds resonable to me, seeing the API already allows it

@dentarg dentarg added the api or backend Needs to be addressed in the API backend label Oct 13, 2023
@dentarg
Copy link
Member

dentarg commented Nov 15, 2023

We have #216 for this

However, we ran into some backend challenges that are yet to be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api or backend Needs to be addressed in the API backend enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants