Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require.js file now being written to project root #93

Open
ajmichels opened this issue Jul 10, 2017 · 2 comments
Open

require.js file now being written to project root #93

ajmichels opened this issue Jul 10, 2017 · 2 comments

Comments

@ajmichels
Copy link

I am just creating this issue since it doesn't appear to exist yet. I am not sure what the best solution is. I am going to try to summarize the problem as best as I can.

As reported in gruntjs/grunt-contrib-jasmine#255, an update was made to gruntjs/grunt-contrib-jasmine which has caused the location of temporary files to change. This means that when _SpecRunner.html (a generated files) is executed it cannot locate the require.js file and task fails.

This issue results in output similar to this:

>> ReferenceError: Can't find variable: require at
>> http:/127.0.0.1:8001/_SpecRunner.html:30 global code
>> ReferenceError: Can't find variable: require at
>> http:/127.0.0.1:8001/_SpecRunner.html:46 global code
>> ReferenceError: Can't find variable: require at
>> http:/127.0.0.1:8001/_SpecRunner.html:147 launchTest

Myself and others have found that reverting grunt-contrib-jasmine to version 1.0.3 resolves the issue, however this seems like a far from ideal solution and is by no means a permanent one.

@prantlf
Copy link

prantlf commented Nov 13, 2018

I opened #95 to fix this. I use a different way to copy files to temp directory, compatible with both older and newer versions of grunt-contrib-jasmine than 1.2.0.

These files are copied to the project root instead of to the temp directory with the rest of Jasmine files. grunt-contrib-jasmine broke their interface between 1.0.3 and 1.2.0 without increasing the major version number. (!!!) This should be discussed with grunt-contrib-jasmine developers.

@psharkin
Copy link

@prantlf Is there any chance #95 will be merged to master any time soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants