Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime·support_bmi2 is dropped in Go 1.11 #2

Closed
FiloSottile opened this issue Jun 29, 2018 · 1 comment · Fixed by #3
Closed

runtime·support_bmi2 is dropped in Go 1.11 #2

FiloSottile opened this issue Jun 29, 2018 · 1 comment · Fixed by #3

Comments

@FiloSottile
Copy link

This will not compile with Go 1.11.

bn256/gfp_amd64.s

Line 113 in fd89005

CMPB runtime·support_bmi2(SB), $0

You can use golang.org/x/sys/cpu instead: https://godoc.org/golang.org/x/sys/cpu#pkg-variables
@Bren2010
Copy link
Contributor

Bren2010 commented Jul 2, 2018

Thanks for the heads up! I'll try to get to this before long, as well as fixing darwin/arm64.

@egonelbre egonelbre mentioned this issue Jul 24, 2018
Closed
@Ko- Ko- mentioned this issue Aug 2, 2018
Merged
@zjshen14 zjshen14 mentioned this issue Sep 3, 2018
Closed
@gabbifish gabbifish mentioned this issue Oct 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Go 1.11 compatibility. Ko-/bn256
2 participants
@Bren2010 @FiloSottile