Clarify that CAP_NET_ADMIN is required #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the current wording of the README, I thought boringtun could run without `CAP_NET_ADMIN`- but it can't at all, failing with:
```
2023-01-04T23:37:51.496375Z ERROR boringtun_cli: Failed to initialize tunnel, error: IOCtl("Operation not permitted")
```
It looks like this originates from `ioctl(fd, TUNSETIFF as _, &ifr)`, which is a privileged operation.
I think I'm not the only one to make this mistake (cloudflare#117), so this clarifies that `CAP_NET_ADMIN` is required.
jeff-hiner
approved these changes
Feb 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the current wording of the README, I thought boringtun could run without
CAP_NET_ADMIN- but it can't at all, failing with:It looks like this originates from
ioctl(fd, TUNSETIFF as _, &ifr), which is a privileged operation.I think I'm not the only one to make this mistake (#117), so this clarifies that
CAP_NET_ADMINis required.