Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP/3 Tutorial: curl installation instructions do not work #2970

Closed
sharpobject opened this issue Dec 16, 2021 · 10 comments
Closed

HTTP/3 Tutorial: curl installation instructions do not work #2970

sharpobject opened this issue Dec 16, 2021 · 10 comments
Assignees
Labels
documentation Documentation edits technical review Issue or PR needs technical review

Comments

@sharpobject
Copy link

At https://developers.cloudflare.com/http3/tutorials/curl-brew the user is instructed to install a certain version of curl using homebrew.

Expected Behavior

The installation succeeds.

Actual Behavior

$ brew install --HEAD -s curl.rb
Error: Failed to load cask: curl.rb
Cask 'curl' is unreadable: wrong constant name #<Class:0x0000000131ae5a60>
Warning: Treating curl.rb as a formula.
==> Cloning https://github.com/curl/curl.git
Cloning into '/Users/sharpobject/Library/Caches/Homebrew/curl--git'...
==> Checking out branch master
Already on 'master'
Your branch is up to date with 'origin/master'.
==> autoreconf -fi
==> git clone --recursive https://github.com/cloudflare/quiche
Error: An exception occurred within a child process:
  Utils::Inreplace::Error: inreplace failed
Cargo.toml:
  expected replacement of /^crate-type = .*/ with "crate-type = [\"staticlib\"]"
@sharpobject sharpobject added the documentation Documentation edits label Dec 16, 2021
@kodster28 kodster28 added the technical review Issue or PR needs technical review label Dec 16, 2021
@kodster28
Copy link
Contributor

Howdy @LPardue, is this something you'd be able to help with?

@Njones11x
Copy link

I believe it was broken by this

cloudflare/quiche@bbe6e2a

Njones11x referenced this issue in cloudflare/quiche Dec 22, 2021
This should make it easier to add new crates to the repo (e.g. no need
to add CI jobs for each one), and just generally makes more sense than
stuffing everything that is not quiche itself under tools/.

Pretty much all the changes are related to build scripts and related
things. All the actual code is just moved around.
@LPardue
Copy link
Contributor

LPardue commented Dec 22, 2021

Yeah that's most likely it, just need to tweak a few things to make it consistent with the new layout. Sorry we missed this

@junhochoi
Copy link
Contributor

I'll take a look.

@x2q
Copy link

x2q commented Jan 15, 2022

+1

@junhochoi
Copy link
Contributor

junhochoi commented Jan 19, 2022

I made a PR for updating homebrew formula: cloudflare/homebrew-cloudflare#43
brew install --HEAD -d -s ./curl.rb will install curl 7.81.0 + quiche master.

Building from curl master (--HEAD) builds ok but it need -k when using --http3. looking

@junhochoi
Copy link
Contributor

junhochoi commented Jan 19, 2022

The problem above is solved and curl master + quiche master works ok. Anyone can try?

@junhochoi
Copy link
Contributor

Can anyone verify cloudflare/homebrew-cloudflare#43 works?
If it works I will merge it.

@sharpobject @Njones11x @x2q

@junhochoi
Copy link
Contributor

cloudflare/homebrew-cloudflare#43 is merged. No changes needed on the documentation.

@cj-scott-prive
Copy link

It looks like this documentation has been removed? : https://developers.cloudflare.com/http3/tutorials/curl-brew now just redirects to HTTP/3 info.

Since HTTP3 support still isn't mainstreamed into the Curl project, the cloudflare patch and docs for Mac Homebrew are quite useful. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation edits technical review Issue or PR needs technical review
Projects
None yet
Development

No branches or pull requests

8 participants