Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for DNS comments and tags #1151

Merged
merged 10 commits into from
Dec 28, 2022

Conversation

Cyb3r-Jak3
Copy link
Contributor

Description

Adds support for the new DNS comments and tags. There is a breaking change because I updated DNSRecords to support the new listing pagination.

Has your change been tested?

New test has been created and all tests pass

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@github-actions
Copy link
Contributor

changelog detected ✅

@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2022

Codecov Report

Merging #1151 (0efc211) into master (6153c1e) will increase coverage by 0.06%.
The diff coverage is 92.59%.

@@            Coverage Diff             @@
##           master    #1151      +/-   ##
==========================================
+ Coverage   49.40%   49.46%   +0.06%     
==========================================
  Files         127      127              
  Lines       12290    12303      +13     
==========================================
+ Hits         6072     6086      +14     
+ Misses       4840     4839       -1     
  Partials     1378     1378              
Impacted Files Coverage Δ
utils.go 72.72% <ø> (ø)
dns.go 68.69% <92.45%> (+4.97%) ⬆️
workers.go 57.14% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

dns.go Outdated Show resolved Hide resolved
dns.go Outdated Show resolved Hide resolved
@jacobbednarz jacobbednarz merged commit 2061a27 into cloudflare:master Dec 28, 2022
@github-actions github-actions bot added this to the v0.58.0 milestone Dec 28, 2022
github-actions bot pushed a commit that referenced this pull request Dec 28, 2022
@Cyb3r-Jak3 Cyb3r-Jak3 deleted the dns-comments-tags branch December 28, 2022 01:07
@janik-cloudflare
Copy link
Member

Wow, thanks for this @Cyb3r-Jak3! Just noticed the merge conflict on #1158, turns out because you already added it! 🎉

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

This functionality has been released in v0.58.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants