Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user_seat_expiration_inactive_time field to Access org #1159

Merged

Conversation

Justin-Holmes
Copy link
Contributor

Description

Adds the user_seat_expiration_inactive_time field to Access organizations. API docs will be updated soon to show this new field as well.

Types of changes

  • New feature (non-breaking change which adds functionality)

@github-actions
Copy link
Contributor

github-actions bot commented Dec 28, 2022

changelog detected ✅

@codecov-commenter
Copy link

Codecov Report

Merging #1159 (11efaeb) into master (6153c1e) will decrease coverage by 0.11%.
The diff coverage is 50.67%.

@@            Coverage Diff             @@
##           master    #1159      +/-   ##
==========================================
- Coverage   49.40%   49.29%   -0.12%     
==========================================
  Files         127      128       +1     
  Lines       12290    12397     +107     
==========================================
+ Hits         6072     6111      +39     
- Misses       4840     4885      +45     
- Partials     1378     1401      +23     
Impacted Files Coverage Δ
access_organization.go 64.70% <ø> (ø)
utils.go 72.72% <ø> (ø)
mtls_certificates.go 26.59% <26.59%> (ø)
dns.go 68.69% <92.45%> (+4.97%) ⬆️
workers.go 57.14% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@jacobbednarz jacobbednarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the API docs land and you add in a changelog entry 👍

@jacobbednarz jacobbednarz merged commit ccde2e7 into cloudflare:master Jan 5, 2023
@github-actions github-actions bot added this to the v0.59.0 milestone Jan 5, 2023
github-actions bot pushed a commit that referenced this pull request Jan 5, 2023
@Justin-Holmes Justin-Holmes deleted the jholmes/user-seat-expiration branch January 6, 2023 05:33
ivan-section-io pushed a commit to section/cloudflare-go that referenced this pull request Jan 12, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v0.59.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants