Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WDAPI-1221 Fix Update Method to be PUT from PATCH #1172

Merged
merged 2 commits into from
Jan 9, 2023

Conversation

suhrit-cf
Copy link
Contributor

@suhrit-cf suhrit-cf commented Jan 9, 2023

Provide a general summary of your changes in the title above. You should
remove this overview, any sections and any section descriptions you
don't need below before submitting. There isn't a strict requirement to
use this template if you can structure your description and still cover
these points.

Description

Bug fix change update method from PATCH To PUT which API expects

Has your change been tested?

Yes Locally using terraform-provider as well.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2023

changelog detected ✅

@jacobbednarz jacobbednarz merged commit 2a418bf into cloudflare:master Jan 9, 2023
@jacobbednarz
Copy link
Member

thanks @suhrit-cf 👏

@github-actions github-actions bot added this to the v0.59.0 milestone Jan 9, 2023
github-actions bot pushed a commit that referenced this pull request Jan 9, 2023
ivan-section-io pushed a commit to section/cloudflare-go that referenced this pull request Jan 12, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v0.59.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants