Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dns: test empty DNS record IDs #1174

Merged
merged 3 commits into from
Jan 10, 2023

Conversation

favonia
Copy link
Contributor

@favonia favonia commented Jan 10, 2023

Description

  1. Check whether DNS record IDs are empty in DeleteDNSRecord (my oversight in dns: UpdateDNSRecord: clean up params and drop record lookup #1170)
  2. Add test cases for empty DNS record IDs for GetDNSRecord, UpdateDNSRecord, and DeleteDNSRecord
  3. Use assert/require.ErrorIs to compare errors during testing

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@favonia favonia changed the title dns: test empty record ids dns: test empty DNS record ids Jan 10, 2023
@favonia favonia changed the title dns: test empty DNS record ids dns: test empty DNS record IDs Jan 10, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 10, 2023

changelog detected ✅

@jacobbednarz jacobbednarz merged commit 32f8e9d into cloudflare:master Jan 10, 2023
@github-actions github-actions bot added this to the v0.59.0 milestone Jan 10, 2023
github-actions bot pushed a commit that referenced this pull request Jan 10, 2023
@favonia favonia deleted the test-empty-record-ids branch January 10, 2023 22:26
ivan-section-io pushed a commit to section/cloudflare-go that referenced this pull request Jan 12, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v0.59.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants