Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UpdateQueue function now matches API docs and allows a Queue's name t… #1188

Merged

Conversation

jbw1991
Copy link
Contributor

@jbw1991 jbw1991 commented Jan 27, 2023

Description

The existing UpdateQueue implementation was not quite correct. The API endpoint only allows for updating a Queue's name. The existing name is passed in the URL, while the new name is passed as a parameter in the body. This PR updates the function to match the API expectations.

Has your change been tested?

  • Updated unit test
  • Tested manually with local terraform provider changes to update a Queue's name

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2023

changelog detected ✅

@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2023

Codecov Report

Merging #1188 (480957e) into master (6153c1e) will decrease coverage by 0.05%.
The diff coverage is 49.79%.

@@            Coverage Diff             @@
##           master    #1188      +/-   ##
==========================================
- Coverage   49.40%   49.36%   -0.05%     
==========================================
  Files         127      128       +1     
  Lines       12290    12430     +140     
==========================================
+ Hits         6072     6136      +64     
- Misses       4840     4890      +50     
- Partials     1378     1404      +26     
Impacted Files Coverage Δ
access_organization.go 64.70% <ø> (ø)
cloudflare.go 68.08% <0.00%> (-0.63%) ⬇️
cloudflare_experimental.go 0.00% <0.00%> (ø)
magic_transit_ipsec_tunnel.go 46.15% <ø> (ø)
teams_rules.go 44.94% <0.00%> (-0.52%) ⬇️
utils.go 72.72% <ø> (ø)
mtls_certificates.go 26.59% <26.59%> (ø)
workers_bindings.go 67.44% <40.00%> (-2.31%) ⬇️
origin_ca.go 57.26% <90.90%> (-2.09%) ⬇️
dns.go 72.72% <96.36%> (+9.00%) ⬆️
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

queue.go Outdated Show resolved Hide resolved
@jbw1991 jbw1991 force-pushed the jwheeler/fix-update-queue-function branch from 521d06d to 480957e Compare January 30, 2023 15:44
@jacobbednarz jacobbednarz merged commit 41460de into cloudflare:master Jan 30, 2023
@jacobbednarz
Copy link
Member

thanks!

@github-actions github-actions bot added this to the v0.60.0 milestone Jan 30, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v0.60.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants