Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change DLP Profile allowed_match_count to int #1200

Merged
merged 2 commits into from
Feb 7, 2023

Conversation

pierreca
Copy link
Contributor

@pierreca pierreca commented Feb 7, 2023

Description

the uint type does not play well with the terraform provider, and given the bounds of this field are 0-1000, an int is sufficient.

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

changelog detected ✅

@codecov-commenter
Copy link

Codecov Report

Merging #1200 (775780c) into master (c07adfc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1200   +/-   ##
=======================================
  Coverage   49.36%   49.36%           
=======================================
  Files         128      128           
  Lines       12430    12430           
=======================================
  Hits         6136     6136           
  Misses       4890     4890           
  Partials     1404     1404           
Impacted Files Coverage Δ
dlp_profile.go 37.93% <ø> (ø)
dns.go 72.72% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jacobbednarz jacobbednarz merged commit 9f67851 into cloudflare:master Feb 7, 2023
@github-actions github-actions bot added this to the v0.61.0 milestone Feb 7, 2023
github-actions bot pushed a commit that referenced this pull request Feb 7, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v0.61.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants