Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DLP-809: Add support for DLP payload logging rule/account settings #1212

Merged
merged 1 commit into from
Feb 25, 2023
Merged

DLP-809: Add support for DLP payload logging rule/account settings #1212

merged 1 commit into from
Feb 25, 2023

Conversation

OrionNebula
Copy link

Description

DLP recently added support for partial payload logging, which will log a portion region of matching requests and encrypt it using a user-provided public key. This PR adds support for setting that public key and enabling payload logging for individual rules.

Has your change been tested?

The change includes unit tests to cover the new functions. These tests match the actual responses given/URLs used by the public API.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2023

changelog detected ✅

dlp_payload_log.go Outdated Show resolved Hide resolved
dlp_payload_log.go Outdated Show resolved Hide resolved
@jacobbednarz
Copy link
Member

thanks! a couple of small nitpicks but overall looking good!

@OrionNebula
Copy link
Author

I think I've addressed your comments, if you want to take another look

@jacobbednarz jacobbednarz merged commit d3fcc6c into cloudflare:master Feb 25, 2023
@jacobbednarz
Copy link
Member

thanks @OrionNebula

@github-actions github-actions bot added this to the v0.62.0 milestone Feb 25, 2023
github-actions bot pushed a commit that referenced this pull request Feb 25, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

This functionality has been released in v0.62.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants