Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "additionalProperties" support #52

Closed
handrews opened this issue May 2, 2017 · 3 comments
Closed

Fix "additionalProperties" support #52

handrews opened this issue May 2, 2017 · 3 comments

Comments

@handrews
Copy link
Contributor

handrews commented May 2, 2017

It is currently implemented mostly like "properties" but with the additional ability to merge into the results of an adjacent allOf/oneOf/anyOf. However, per the spec, "properties" already behaves this way (adjacent schema keywords are effectively an additional branch of an implicit allOf anyway). And "additionalProperties" takes a single schema, not a set of names.

This is a json-schema-example-loader issue in object-definition.js

@handrews handrews added the bug label May 2, 2017
@handrews
Copy link
Contributor Author

handrews commented May 2, 2017

Part of this is also in json-schema-example-loader's example-data-extractor.js

@handrews
Copy link
Contributor Author

handrews commented May 8, 2017

I took the "theme" label off because we were not displaying "additionalProperties" before, so the part of this that is a bug fix is just in json-schema-example-loader.

Adding "additionalProperties" to the theme can be a separate, lower priority issue.

@handrews
Copy link
Contributor Author

This should have been closed with the example-loader fix back in May, I believe. Although the current bootstrap theme cannot make use of it, that's no worse than it was.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant