New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Queues Support #354
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! ✅ Thanks for breaking this up into smaller PRs previously. 🙂 Would you be able to fix the lint warnings (npm run lint
) then I'm happy to merge. 👍
Thanks @mrbbot! Just fixed those warnings. |
Great, thank you! Just noticed there are lots of changes to the |
Whoops sorry, I probably did something silly to screw up the package-lock. I'm using node version 18.7.0 and npm version 8.15.0. I'll have to get this merged/released before I can update the dependency in wrangler branch, right? Unless there is some way to do a custom miniflare release/version (and then update my wrangler branch to point at that?). |
We can publish this to miniflare/packages/core/src/plugins/bindings.ts Lines 324 to 328 in 8a8c5ae
|
Thanks @mrbbot, l think it makes sense to do a regular miniflare release. I believe I have fixed the package-lock issues, and added the warning log message you suggested. I'm not sure what's up with the failing test on Windows, is that flakiness or did I break that test somehow? |
This looks like a flaky test. I'll try investigate it quickly, but will probably just disable it on Windows. 👍 |
Actually, just noticed the Miniflare logger wasn't being used in some places. Since I'd like to get this out today, I've gone ahead and made the change. Does this look ok to you? |
Yes, looks great, you are too kind! Feel free to merge (+squash if desired) whenever you are ready. |
Pulling over the commits from my private fork.
Also added two new commits to clean up some temporary docs, and adjust to the latest desired wrangler config for queues.
I'm hoping to get this cleaned up and merged so that I can begin integrating it into the wrangler
queues
branch.