Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R2Bucket.put() gets stuck indefinitely in using the getBindigns() ProxyStub #670

Closed
TimoWilhelm opened this issue Aug 29, 2023 · 2 comments

Comments

@TimoWilhelm
Copy link

After migrating to the new *magic* proxy getBindings() implementation in Miniflare 3, I noticed that storing new blobs in R2 through the proxy stub get stuck indefinitely.

Looking at the .miniflare directory it seems like the blob is uploaded correctly. However, the call never completes and eventually fails with a fetch timeout.

I've included a Minimal, Reproducible Example here https://github.com/TimoWilhelm/mre-miniflare-r2-bindings

Environment

Node: v20.5.1
miniflare: 3.20230821.0

@mrbbot
Copy link
Contributor

mrbbot commented Aug 29, 2023

Hey! 👋 I think this is the same issue as cloudflare/workers-sdk#3626 (comment). I think this may be caused by nodejs/node#48668, which was introduced in Node 20.4.0. It looks like Node 20.3.0 doesn't reproduce this issue, so I'd stick with that for the time being. I'll close this issue, since there's not much we can do until the next Node release. 👍 In your reproduction, you'll want to add await mf.dispose() at the end of your script too, so the process can exit cleanly.

@mrbbot mrbbot closed this as completed Aug 29, 2023
@TimoWilhelm
Copy link
Author

Thanks for the quick reply 🙌 I must have missed the other issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants