Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Https-proxy-agent needs updating #57

Closed
justinasfour04 opened this issue Apr 8, 2020 · 14 comments
Closed

Https-proxy-agent needs updating #57

justinasfour04 opened this issue Apr 8, 2020 · 14 comments
Assignees
Labels
dependencies Pull requests that update a dependency file
Milestone

Comments

@justinasfour04
Copy link

We are using cloudflare-node version 2.7.0 and cannot use got due to the related issue.
cloudflare has a dependency that needs updating
cloudflare@2.7.0
└─┬ https-proxy-agent@2.2.4
└── agent-base@4.3.0

related issue:
sindresorhus/got#1039

@terinjokes
Copy link
Contributor

That's unfortunate. It definitely worked when I implemented it.

I've added this to my todo list.

@justinasfour04
Copy link
Author

@terinjokes Is this PR going to get updated #54 ?

@terinjokes
Copy link
Contributor

I'm unsure, I'll be able to take a look this weekend.

@naseemkullah
Copy link

@terinjokes we are at a fork in road here, we believe in OSS and love this lib but if it cannot be maintained a little more we will use the cloudflare API directly as it is a current blocker.

With that said how do you feel about adding @justinasfour04 (or someone else) as a maintainer of this lib and making it more of a communal effort, considering it is not an official Cloudflare product?

@terinjokes
Copy link
Contributor

I started working on this over the weekend. Unfortunately, I ran out of time before completing it. I plan on continuing this week.

@terinjokes terinjokes self-assigned this Apr 14, 2020
@naseemkullah
Copy link

Thanks @terinjokes

@terinjokes terinjokes added this to the 3.0.0 milestone Apr 14, 2020
@terinjokes terinjokes added the dependencies Pull requests that update a dependency file label Apr 14, 2020
@justinasfour04
Copy link
Author

justinasfour04 commented Apr 14, 2020

Just out of curiosity why did you not answer the question that @naseemkullah asked about adding on more maintainers to the project? If you do not have time to keep the project maintained and teams from around the world need it then why not ask for help?

@terinjokes
Copy link
Contributor

Pull requests are accepted, but at this time I don't plan on adding additional maintainers. I suspect this will change in the future.

@justinasfour04
Copy link
Author

I removed this library from my project and got works. Not sure what the status is on the fix but for now you lost a developer using this library

@terinjokes
Copy link
Contributor

This is being removed in the next version, 3.0.0 which you can track in the 3.0.0 milestone

@justinasfour04
Copy link
Author

oh nice ok. I'll keep my eye out

@terinjokes
Copy link
Contributor

Can someone encountering this issue, and still using this library, take a look at the fix proposed in #67 and confirm it works in their environment?

@Stono
Copy link

Stono commented Jun 23, 2020

Hey folks, any change we could get some traction on this? It causes us quite a bit of pain. Alex has done the work in the PR and tested it on our apps that use this library at AutoTrader, i'm not sure what else we need to do?

@naseemkullah
Copy link

I removed this library from my project and got works. Not sure what the status is on the fix but for now you lost a developer using this library

Just to clarify, we no longer use the lib and are not planning to go back for the time being, as such we are no longer in a place to comment about it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

4 participants