Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test source code directly #2

Closed
lukeed opened this issue Jun 10, 2022 · 0 comments · Fixed by #3
Closed

test source code directly #2

lukeed opened this issue Jun 10, 2022 · 0 comments · Fixed by #3

Comments

@lukeed
Copy link

lukeed commented Jun 10, 2022

This line:

import { isValidBrokerRequest } from "../dist/index.js";

Should be:

import { isValidBrokerRequest } from "../src";

This is so that you can always run npm test without needing to rebuild the project first.

This is necessary as of 037070f#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L18 since the pretest tsc step was removed.. so right now tests are always testing outdated code unless you're doing npm run build && npm test repeatedly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant