New data source - cloudflare_origin_ca_root_certificate

[onematchfox]

Introduces new data source cloudflare_origin_ca_root_certificate which can be used to read the Origin CA root certificate for a given algorithm.

Closes #1096

[jacobbednarz]

some minor nitpicks but nothing major 👍 once we get those sorted, this looks fine to merge in.

[jacobbednarz]

integration tests look good

TF_ACC=1 go test $(go list ./...) -v -run "^TestAccCloudflareOriginCARootCertificate" -count 1 -timeout 120m -parallel 1
?   	github.com/cloudflare/terraform-provider-cloudflare	[no test files]
=== RUN   TestAccCloudflareOriginCARootCertificate
--- PASS: TestAccCloudflareOriginCARootCertificate (0.76s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/cloudflare	1.138s
?   	github.com/cloudflare/terraform-provider-cloudflare/version	[no test files]

[onematchfox]

some minor nitpicks but nothing major once we get those sorted, this looks fine to merge in.

Thanks for the review. Accepted all suggestions. Hope you don't mind me tagging an extra commit on to the PR - I took the liberty of fixing the ip_range sidebar annotations so that these are no longer the odd ones out with their use of _ instead of -

[onematchfox]

Hi @jacobbednarz, Just checking in on this PR to make sure it hasn't dropped off your radar. Let me know if there's anything else you need me to do. Cheers.

[jacobbednarz]

this definitely hasn't fallen off my radar; just a little swamped this week coming back from vacation :) will hopefully wrap this up this week at some point.

[jacobbednarz]

🥳 thanks for this!

[nboaldin]

cloudflare_origin_ca_root_certificate is returning html code for me, not an actual cert. Wanted to poke in here before I open up an issue.

[onematchfox]

cloudflare_origin_ca_root_certificate is returning html code for me, not an actual cert. Wanted to poke in here before I open up an issue.

Yeah, unfortunately Cloudflare adjusted the URLs that were being used to retrieve the certs. This has been fixed in cloudflare/cloudflare-go#819 but we'll need to wait for a new release of that library to be able to fix this one.

cc @jacobbednarz