Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GATE-2256: Set the gateway FIPS config #1380

Conversation

adamchalmers
Copy link
Contributor

I expect this PR to make the acceptance test fail -- I won't make it pass until I see it fail first.

@github-actions
Copy link
Contributor

Oops! It looks like no changelog entry is attached to this PR. Please include a release note as described in https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/docs/changelog-process.md.

Example:

```release-note:TYPE
Release note
```

If you do not require a release note to be included, please add the workflow/skip-changelog-entry label.

@jacobbednarz
Copy link
Member

jacobbednarz commented Jan 13, 2022

acceptance tests don't run against PRs as they create real resources. the CONTRIBUTING guide outlines how to get acceptance tests run locally.

hit me up if you need a hand getting these to run and fail as you expect.

@adamchalmers
Copy link
Contributor Author

OK, I was hoping I wouldn't have to create resources as I've never used terraform and wouldn't know how to delete them after.

Also, this PR is 1380, but .changelog/1380.txt already exists -- any suggestions for how to resolve that conflict?

@jacobbednarz
Copy link
Member

OK, I was hoping I wouldn't have to create resources as I've never used terraform and wouldn't know how to delete them after.

If you write tests and have the Delete method implemented in the resource, Terraform calls this before exiting the test so it should clean up automatically.

Also, this PR is 1380, but .changelog/1380.txt already exists -- any suggestions for how to resolve that conflict?

Apologies, that was me testing and ended up committing the wrong ID. I've resolved this now.

@adamchalmers adamchalmers force-pushed the achalmers/GATE-2256-cf-teams-fips-gateway branch 5 times, most recently from 2d396a6 to be1ce3d Compare January 13, 2022 05:53
@adamchalmers adamchalmers force-pushed the achalmers/GATE-2256-cf-teams-fips-gateway branch from be1ce3d to c49a908 Compare January 13, 2022 05:54
Copy link
Member

@jacobbednarz jacobbednarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR is good to go however, we do have permadiff to address down the track

TF_ACC=1 go test $(go list ./...) -v -run "^TestAccCloudflareTeamsAccountConfigurationBasic" -count 1 -parallel 1 -timeout 120m -parallel 1
?   	github.com/cloudflare/terraform-provider-cloudflare	[no test files]
=== RUN   TestAccCloudflareTeamsAccountConfigurationBasic
    resource_cloudflare_teams_accounts_test.go:25: Step 1/1 error: After applying this test step, the plan was not empty.
        stdout:


        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place

        Terraform will perform the following actions:

          # cloudflare_teams_account.dzbxtynnii will be updated in-place
          ~ resource "cloudflare_teams_account" "dzbxtynnii" {
              - activity_log_enabled = true -> null
                id                   = "f037e56e89293a057740de681ac9abbe"
                # (2 unchanged attributes hidden)



                # (3 unchanged blocks hidden)
            }

        Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccCloudflareTeamsAccountConfigurationBasic (11.22s)
FAIL
FAIL	github.com/cloudflare/terraform-provider-cloudflare/cloudflare	11.528s
?   	github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/changelog-check	[no test files]
?   	github.com/cloudflare/terraform-provider-cloudflare/version	[no test files]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants