Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudflare_access_application not idempotent with http_only_cookie_attribute attribute to false #1561

Closed
2 tasks done
DamienDelporte opened this issue Apr 12, 2022 · 4 comments · Fixed by #1619
Closed
2 tasks done
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/needs-information Indicates an issue needs more information in order to work on it.

Comments

@DamienDelporte
Copy link

Confirmation

  • My issue isn't already found on the issue tracker.
  • I have replicated my issue using the latest version of the provider and it is still present.

Terraform and Cloudflare provider version

$ terraform -v
Terraform v0.14.11
+ provider registry.terraform.io/cloudflare/cloudflare v3.11.0

Affected resource(s)

  • cloudflare_access_application

Terraform configuration files

resource "cloudflare_access_application" "test" {
  account_id                = var.account_id
  name                      = "test.doctolib.com"
  domain                    = "test.doctolib.com"
  session_duration          = "3h"
  auto_redirect_to_identity = true
  same_site_cookie_attribute = "none"
  http_only_cookie_attribute = false
  enable_binding_cookie = false

  cors_headers {
    allowed_origins   = ["test.doctolib.com"]
    allow_credentials = false
    allow_all_methods = true
    max_age           = 30
  }
}

Debug output

Not needed.

Panic output

None.

Expected output

Nothing to be changed after creation.

Actual output

  # cloudflare_access_application.test will be updated in-place
  ~ resource "cloudflare_access_application" "test" {
      ~ http_only_cookie_attribute = true -> false
        id                         = "xxx"
        name                       = "test.doctolib.com"
        # (11 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

Steps to reproduce

  1. terraform apply (to create ressource)
  2. terraform apply (to see the problem, and try to apply again (why not))
  3. terraform apply (problem still here)

Additional factoids

No response

References

No response

@DamienDelporte DamienDelporte added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 12, 2022
@github-actions
Copy link
Contributor

Thank you for reporting this issue! For maintainers to dig into issues it is required that all issues include the entirety of TF_LOG=DEBUG output to be provided. The only parts that should be redacted are your user credentials in the X-Auth-Key, X-Auth-Email and Authorization HTTP headers. Details such as zone or account identifiers are not considered sensitive but can be redacted if you are very cautious. This log file provides additional context from Terraform, the provider and the Cloudflare API that helps in debugging issues. Without it, maintainers are very limited in what they can do and may hamper diagnosis efforts.

This issue has been marked with triage/needs-information and is unlikely to receive maintainer attention until the log file is provided making this a complete bug report.

@github-actions github-actions bot added triage/needs-information Indicates an issue needs more information in order to work on it. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 12, 2022
@chaoqi
Copy link

chaoqi commented May 3, 2022

Hi @DamienDelporte, I also have the exact same problems. The HttpOnly is by default "Enabled" and i can NOT set this to be disabled by setting http_only_cookie_attribute = false using Terraform.

@DamienDelporte
Copy link
Author

Thank you so much !

@DamienDelporte
Copy link
Author

Hello @jacobbednarz would you be able to give us an approximate release date for the fixed terraform provider ? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/needs-information Indicates an issue needs more information in order to work on it.
Projects
None yet
2 participants